Fix empty drawer after publish conversation#192
Merged
mariobalca merged 1 commit intomainfrom Nov 9, 2022
Merged
Conversation
❌ Deploy Preview for open-devfounders failed.
|
❌ Deploy Preview for open-crowd-prod failed.
|
mariobalca
approved these changes
Nov 9, 2022
Contributor
mariobalca
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Looks good to me 👍
Will merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
Issue:
After publishing/unpublishing a conversation, the conversation drawer opens with no details inside - Task
Approach:
community-help-center-table.vuecomponent. Prevent rerender of entire component when rows/conversations are updated after being fetched in the update request.community-help-center-page.vue. In here, the drawer won't be affected by the table update after the most recent fetch of the table rows.Checklist ✅
type:feature 🚀,type:enhancement ✨,type:bug 🐞, ortype:documentation 📜.frontend/.env.distbackend/.env.dist,backend/.env.dist.staging,backend/.env.dist.staging.